linux-kernel - Re: [PATCH v5 00/34] staging: rtl8192e: Fix more checkpatch.pl warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1433097568.2984.31.camel@perches.com>
Date:	Sun, 31 May 2015 11:39:28 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
Cc:	gregkh@...uxfoundation.org, dan.carpenter@...cle.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 00/34] staging: rtl8192e: Fix more checkpatch.pl
 warnings

On Sun, 2015-05-31 at 20:19 +0200, Mateusz Kulikowski wrote:
> Updated series of patches for rtl8192.
[]
>  31 files changed, 1260 insertions(+), 2011 deletions(-)

Nice diffstat

btw:

If you have to resubmit this, please try to remove
the unnecessary periods after logging statements.

Things like:

-                               RT_TRACE(COMP_ERR,
-                                        "PHY_SetRF8256Bandwidth(): unknown hardware version\n");
+                               netdev_warn(dev, "%s(): Unknown HW version.\n",
+                                           __func__);

aren't sentences and don't need punctuation.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/