linux-kernel - Re: [PATCH] staging: me_daq: use schedule_timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150531011926.GB13096@kroah.com>
Date:	Sun, 31 May 2015 10:19:26 +0900
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Nicholas Mc Guire <der.herr@...r.at>
Cc:	Ian Abbott <abbotti@....co.uk>, devel@...verdev.osuosl.org,
	Davidlohr Bueso <dave@...olabs.net>,
	linux-kernel@...r.kernel.org,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Nicholas Mc Guire <hofrat@...dl.org>
Subject: Re: [PATCH] staging: me_daq: use schedule_timeout_interruptible()

On Fri, May 29, 2015 at 06:47:28PM +0200, Nicholas Mc Guire wrote:
> On Fri, 29 May 2015, Ian Abbott wrote:
> 
> > On 29/05/15 16:58, Nicholas Mc Guire wrote:
> >> API consolidation with coccinelle found:
> >> ./drivers/staging/comedi/drivers/me_daq.c:177:1-17:
> >>          consolidation with schedule_timeout_*() recommended
> >>
> >> This is a 1:1 conversion of the current calls to an available helper
> >> only - so only an API consolidation to improve readability.
> >>
> >> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
> >> CONFIG_COMEDI=y, CONFIG_COMEDI_PCI_DRIVERS=y CONFIG_COMEDI_ME_DAQ=m
> >>
> >> Patch is against 4.1-rc5 (localversion-next is -next-20150529)
> >
> > Minor niggle: you don't really need to say what version the patch is  
> > against in the commit message, as the version will have changed by the  
> > time the patch is committed.  It can be mentioned after the "---" marker  
> > line if relevant, as the stuff after the "---" line does not end up in  
> > the commit message.
> >
> makes sense - will move that down for the other cleanups.

Please fix up and resend so I don't have to hand-edit the patch.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/