linux-kernel - Re: [PATCH] drivers: xen-blkfront: blkif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Jun 2015 09:50:28 +0200
From:	Roger Pau Monné <roger.pau@...rix.com>
To:	Bob Liu <bob.liu@...cle.com>, <xen-devel@...ts.xen.org>
CC:	<david.vrabel@...rix.com>, <justing@...ctralogic.com>,
	<konrad.wilk@...cle.com>, <paul.durrant@...rix.com>,
	<julien.grall@...rix.com>, <boris.ostrovsky@...cle.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: xen-blkfront: blkif_recover: recheck feature-persistent

El 26/05/15 a les 2.11, Bob Liu ha escrit:
> When migrate from !feature-persistent host to feature-persistent host, domU
> still think new host/backend don't support persistent.
> Dmesg like:
> backed has not unmapped grant: 839
> backed has not unmapped grant: 773
> backed has not unmapped grant: 773
> backed has not unmapped grant: 773
> backed has not unmapped grant: 839
> 
> We should recheck whether the new backend support feature-persistent during
> blkif_recover().

Right, we recheck for indirect-descriptors but not persistent grants.

Do you think it makes sense to split the part of blkfront_connect that
checks for optional features, like persistent grants, indirect
descriptors and flush/barrier features to a separate function and call
it from both blkfront_connect and blkif_recover?

Roger.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/