linux-kernel - Re: [PATCH 1/3] perf, tools: Add override support for event list CPUID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150601102944.GC19893@krava.redhat.com>
Date:	Mon, 1 Jun 2015 12:29:44 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	acme@...nel.org, namhyung@...nel.org, eranian@...gle.com,
	linux-kernel@...r.kernel.org, mingo@...nel.org,
	sukadev@...ux.vnet.ibm.com, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 1/3] perf, tools: Add override support for event list
 CPUID

On Sun, May 31, 2015 at 09:11:34AM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> Add a PERF_CPUID variable to override the CPUID of the current CPU.
> This is useful for testing, so that all event lists 

.. within a current architecture (x86, powerpc) ..

> can be tested on a single
> system.
> 
> v2: Fix double free in earlier version.
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> ---
>  tools/perf/util/pmu.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 578a537..5c30f89 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -474,7 +474,11 @@ static int pmu_add_cpu_aliases(void *data)
>  	struct pmu_event *pe;
>  	char *cpuid;
>  
> -	cpuid = get_cpuid_str();
> +	cpuid = getenv("PERF_CPUID");
> +	if (cpuid)
> +		cpuid = strdup(cpuid);
> +	if (!cpuid)
> +		cpuid = get_cpuid_str();
>  	if (!cpuid)
>  		return 0;

I tried and it's hard to actually say you're looking on another
CPU events. Could we advertise the CPUID in perf list? Or at least
some pr_debug print.

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/