linux-kernel - Re: [PATCH] usb: isp1760: fix null dereference if kzalloc returns null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <556C3D69.1030909@cogentembedded.com>
Date:	Mon, 01 Jun 2015 14:09:29 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Colin Ian King <colin.king@...onical.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Felipe Balbi <balbi@...com>,
	Sudeep Holla <sudeep.holla@....com>, linux-usb@...r.kernel.org
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: isp1760: fix null dereference if kzalloc returns
 null

Hello.

On 6/1/2015 1:41 AM, Colin Ian King wrote:

>>> From: Colin Ian King <colin.king@...onical.com>

>>> If kzalloc returns null then isp1760_ep_alloc_request performs
>>> a null pointer deference on req.

>>     Dereference, not "deference".

> Shall I send v2 for this stupid typo then?

    Definitely, especially as your change log doesn't adequately reflect 
reality anyway.

>>     No, it doesn't. It calculates the address of the
>> 'isp1760_request::req' instead, there's no dereference per se. I suppose
>> this is a first member of the structure, so this function should work
>> correctly in any case.

> Well, for now it's the first member, but can we assume that will apply
> forever?

    I guess so.

> As it stands, other *_alloc_request() functions in all the
> other usb drivers check for the NULL, so this fix just aligns the code
> with all of these other drivers.

    OK.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/