linux-kernel - Re: [PATCH 04/10] perf, tools, report: Add processing for cycle histograms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150601130700.GC19417@two.firstfloor.org>
Date:	Mon, 1 Jun 2015 15:07:00 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
	linux-kernel@...r.kernel.org, namhyung@...nel.org,
	eranian@...gle.com, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 04/10] perf, tools, report: Add processing for cycle
 histograms

On Mon, Jun 01, 2015 at 03:02:23PM +0200, Jiri Olsa wrote:
> On Tue, May 26, 2015 at 07:37:30PM +0200, Andi Kleen wrote:
> > > hum, so this is assuming that having cycles fort 1st entry
> > > means there'll be for the rest?
> > > Also in that case why is there the '!= cycles' check within
> > > addr_map_symbol__account_cycles ?
> > >
> > It means there might be. It's just a short cut. But rarely
> > branches may still have 0 cycles, so it still needs to be
> > checked later.
> > 
> > In theory it could miss a valid one if the first happened
> > to be zero, but that seems very unlikely.
> 
> so having 'bs->entries[0].flags.cycles' is the only way
> of knowing that we have the feature enabled?

Yes.

In theory we could add caps in sysfs like the PT code,
but that's not implemented currently.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/