linux-kernel - Re: [PATCH] checkpatch: Make the output better readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 01 Jun 2015 08:50:24 -0700
From:	Joe Perches <joe@...ches.com>
To:	Petr Mladek <pmladek@...e.cz>
Cc:	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Make the output better readable

On Mon, 2015-06-01 at 16:25 +0200, Petr Mladek wrote:
> I always have troubles to parse checkpatch.pl output when I check
> the whole patchset. It is hard to say which messages belongs to
> what patch.
> 
> This patch does few small changes to make the output look better
> for me:
> 
>     + delimit each patch from each other with dashes and empty line
>     + remove empty line after the summary

I've no objection about this, but don't much care either.

>     + print message about false positives only once

This bit seems sensible, thanks.

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -720,8 +720,14 @@ my @fixed_deleted = ();
>  my $fixlinenr = -1;
>  
>  my $vname;
> +my $filenum = 0;
>  for my $filename (@ARGV) {
>  	my $FILE;
> +
> +	if ($filenum++ && $quiet == 0) {
> +		print "--------------------------------------------------------------------------------\n";

Perhaps more perlish would be print '-' x 81 . '\n\n';
Dunno why you chose 81 though, it seems an unusual number.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/