linux-kernel - Re: [PATCHv4 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 01 Jun 2015 09:32:30 -0700
From:	Joe Perches <joe@...ches.com>
To:	Moritz Fischer <moritz.fischer@...us.com>
Cc:	jassisinghbrar@...il.com, linux-kernel@...r.kernel.org,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	michal.simek@...inx.com, soren.brinkmann@...inx.com,
	akpm@...ux-foundation.org, gregkh@...uxfoundation.org,
	mchehab@....samsung.com, arnd@...db.de, jingoohan1@...il.com,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCHv4 2/2] mailbox: Adding driver for Xilinx LogiCORE IP
 mailbox.

On Mon, 2015-06-01 at 09:18 -0700, Moritz Fischer wrote:
> The Xilinx LogiCORE IP mailbox is a FPGA core that allows for
> interprocessor communication via AXI4 memory mapped / AXI4 stream
> interfaces.

trivia:

> diff --git a/drivers/mailbox/mailbox-xilinx.c b/drivers/mailbox/mailbox-xilinx.c
[]
> +static int xilinx_mbox_startup(struct mbox_chan *chan)
> +{
[]
> +			dev_err(mbox->dev,
> +				"failed to register mailbox interrupt:%d\n",
> +				ret);
[]
> +static int xilinx_mbox_probe(struct platform_device *pdev)
> +{
[]
> +		dev_err(&pdev->dev, "Couldn't get clk.\n");
[]
> +		dev_info(&pdev->dev, "IRQ not found, fallback to polling.\n");
[]
> +		dev_err(&pdev->dev, "Register mailbox failed\n");

Perhaps it' be nicer to consistently use a "no-period"
message style.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/