linux-kernel - Re: [PATCH v2 1/3] megaraid : use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo7E85pFOj2FC8BRcbXrvWa3AMTTV2dhW1d=w5BX+POKVA@mail.gmail.com>
Date:	Mon, 1 Jun 2015 11:40:23 -0500
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Kashyap Desai <kashyap.desai@...gotech.com>,
	Uday Lingala <uday.lingala@...gotech.com>,
	Sumit Saxena <sumit.saxena@...gotech.com>,
	"PDL,MEGARAIDLINUX" <megaraidlinux.pdl@...gotech.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	Christoph Hellwig <hch@....de>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] megaraid : use dev_printk when possible

On Mon, Jun 1, 2015 at 11:10 AM, Joe Perches <joe@...ches.com> wrote:
> On Mon, 2015-06-01 at 10:40 -0500, Bjorn Helgaas wrote:
>> Use dev_printk() when possible to make messages more useful.
> []
>> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
> []
>> @@ -268,7 +268,7 @@ mega_query_adapter(adapter_t *adapter)
>>               raw_mbox[2] = NC_SUBOP_PRODUCT_INFO;    /* i.e. 0x0E */
>>
>>               if ((retval = issue_scb_block(adapter, raw_mbox)))
>> -                     printk(KERN_WARNING
>> +                     dev_warn(&adapter->dev->dev,
>>                       "megaraid: Product_info cmd failed with error: %d\n",
>>                               retval);
>
> Wouldn't these be a bit redundant with a "megaraid: " prefix now?
> Perhaps it'd be nicer to realign arguments too.

Yes, you're right.  I took out most of the "megaraid: " prefixes, but
I missed a few.

I tried not to realign things too much because it's hard to know where
to stop, and I don't want to spend a week on this.

I'll post a v3 in a day or two in case there are other comments.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/