linux-kernel - Re: [PATCH 16/16] ARM: at91/dt: Add Acme Arietta G25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150601164859.GM4710@piout.net>
Date:	Mon, 1 Jun 2015 18:48:59 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	Sergio Tanzilli <tanzilli@...esystems.it>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 16/16] ARM: at91/dt: Add Acme Arietta G25

On 01/06/2015 at 18:18:46 +0200, Nicolas Ferre wrote :
> > + */
> > +/dts-v1/;
> > +#include "at91sam9g25.dtsi"
> > +/ {
> > +	model = "Acme Systems Arietta G25";
> > +	compatible = "acme,ariettag25", "atmel,at91sam9x5", "atmel,at91sam9";
> > +
> 
> Don't we need to add a "alias" group here, to be sure that the
> "stdout-path" is always good whatever appends to the underlying
> at91sam9g25.dtsi (nitpicking, I know ;-)) ?
> 

I've just checked and dtc seems to be doing the right thing, I'll do
that.

> > +	chosen {
> > +		stdout-path = "serial0:115200n8";
> > +	};
> > +
> > +	memory {
> > +		reg = <0x20000000 0x8000000>;
> > +	};
> > +
> > +	clocks {
> > +		slow_xtal {
> > +			clock-frequency = <32768>;
> > +		};
> > +
> > +		main_xtal {
> > +			clock-frequency = <12000000>;
> > +		};
> > +	};
> > +
> > +	ahb {
> > +		apb {
> > +			mmc0: mmc@...08000 {
> > +				pinctrl-0 = <
> > +				  &pinctrl_mmc0_slot0_clk_cmd_dat0
> > +				  &pinctrl_mmc0_slot0_dat1_3>;
> > +				status = "okay";
> > +
> > +				slot@0 {
> > +					reg = <0>;
> > +					bus-width = <4>;
> > +				};
> > +			};
> > +
> > +			usb2: gadget@...3c000 {
> > +				status = "okay";
> > +			};
> > +
> > +			dbgu: serial@...ff200 {
> > +				status = "okay";
> > +			};
> > +
> > +			rtc@...ffeb0 {
> > +				status = "okay";
> > +			};
> > +		};
> > +
> > +		usb0: ohci@...00000 {
> > +			status = "okay";
> > +			num-ports = <3>;
> > +		};
> > +
> > +		usb1: ehci@...00000 {
> > +			status = "okay";
> > +		};
> > +	};
> > +
> > +	leds {
> > +		compatible = "gpio-leds";
> > +		arietta_led {
> > +			label = "arietta_led";
> > +			gpios = <&pioB 8 GPIO_ACTIVE_HIGH>; /* PB8 */
> > +			linux,default-trigger = "heartbeat";
> > +		};
> > +	};
> > +};
> > 
> 
> 
> -- 
> Nicolas Ferre

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/