linux-kernel - Re: [PATCH] fuse: avoid clobbering fc->release with fuse_conn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150601172843.GA24635@hudson.localdomain>
Date:	Mon, 1 Jun 2015 10:28:43 -0700
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	fuse-devel <fuse-devel@...ts.sourceforge.net>,
	Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fuse: avoid clobbering fc->release with
 fuse_conn_init(fc)

Miklos,

On Mon, Jun 01, 2015 at 02:03:02PM +0200, Miklos Szeredi wrote:
> On Mon, Jun 1, 2015 at 3:31 AM, Jeremiah Mahler <jmmahler@...il.com> wrote:
> > fuse_conn_init(fc) zeros the entire fc structure before it assigns
> > specific values.  Since fc->release is set before fuse_conn_init(fc)
> > is called, the value gets set to zero, which results in a NULL pointer
> > deference when fc->release() is called.  Fix the problem by assigning
> > fc->release after calling fuse_conn_init(fc) instead of before.
> 
> I added this fix to the original patch and force pushed to
> fuse.git/for-next.  Better keep it in one so that your fix is not left
> out accidentally when being backported to -stable.
> 
> Thanks,
> Miklos
> 

Good idea, thanks :-)

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/