linux-kernel - Re: watchdog: st_wdt: select on undefined MFD_ST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150601175513.GG3329@x1>
Date:	Mon, 1 Jun 2015 18:55:13 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Valentin Rothberg <valentinrothberg@...il.com>
Cc:	Andreas Ruprecht <andreas.ruprecht@....de>,
	Paul Bolle <pebolle@...cali.nl>,
	hengelein Stefan <stefan.hengelein@....de>, wim@...ana.be,
	david.paris@...com, linux-kernel@...r.kernel.org,
	linux-watchdog@...r.kernel.org
Subject: Re: watchdog: st_wdt: select on undefined MFD_ST_LPC

On Mon, 01 Jun 2015, Valentin Rothberg wrote:

> Hi Lee,
> 
> your commit d0c9e350b9a4 ("watchdog: st_wdt: Add new driver for ST's
> LPC Watchdog") is in today's linux-next tree (i.e., next-20150601) and
> adds the following lines of code to drivers/watchdog/Kconfig.
> 
> +config ST_LPC_WATCHDOG
> ...
> +       select MFD_ST_LPC
> 
> The select turns out to be a NOOP since MFD_ST_LPC is not defined
> Kconfig.  Is it the correct option to be selected?  I could not find a
> similar option in the source, nor get any hints  from searching the
> lkml.
> 
> I detected the issue with ./scripts/checkkconfigsymbols.py by diffing
> the last and today's linux tree.

You're right.  This symbol is legacy.  I will remove.

Thanks for reporting.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/