linux-kernel - Re: [PATCH 05/16] staging: wilc1000: remove time wrapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2884986.sC9Qebk6fI@wuerfel>
Date:	Mon, 01 Jun 2015 21:09:36 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Rachel Kim <rachel.kim@...el.com>,
	Dean Lee <dean.lee@...el.com>,
	Chris Park <chris.park@...el.com>, devel@...verdev.osuosl.org,
	nicolas.ferre@...el.com, Johnny Kim <johnny.kim@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/16] staging: wilc1000: remove time wrapper

On Sunday 31 May 2015 08:58:13 Greg KH wrote:
> On Sat, May 30, 2015 at 12:09:23PM +0530, Sudip Mukherjee wrote:
> > On Fri, May 29, 2015 at 10:52:16PM +0200, Arnd Bergmann wrote:
> > > The abstraction for time in this driver is completely
> > > unused, so remove it.
> > > 
> > > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > > ---
> > >  drivers/staging/wilc1000/wilc_osconfig.h  |   1 -
> > >  drivers/staging/wilc1000/wilc_oswrapper.h |   5 -
> > >  drivers/staging/wilc1000/wilc_platform.h  |  12 --
> > >  drivers/staging/wilc1000/wilc_time.c      | 163 ------------------------
> > >  drivers/staging/wilc1000/wilc_time.h      | 205 ------------------------------
> > >  5 files changed, 386 deletions(-)
> > >  delete mode 100644 drivers/staging/wilc1000/wilc_time.c
> > >  delete mode 100644 drivers/staging/wilc1000/wilc_time.h
> > after this patch I am getting:
> > "WARNING: could not open drivers/staging/wilc1000/wilc_time.c: No such file or directory"
> > 
> > wilc_time is mentioned in the Makefile, it should have been removed from
> > there also.
> 
> Ick, not good.

Sorry about that. I had actually made the same mistake before and fixed it up,
but the introduced the bug again and didn't find it during my build testing
because 'make' kept picking up the old object files.

> Arnd, I've applied the first 4 patches, but stopped here, can you respin
> the rest and resend?

Done.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/