linux-kernel - Re: [PATCH] iio: buffer: remove unneeded test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <556C0E33.9050206@kernel.org>
Date:	Mon, 01 Jun 2015 08:48:03 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Laurent Navet <laurent.navet@...il.com>
CC:	knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: buffer: remove unneeded test

On 30/05/15 21:35, Laurent Navet wrote:
> The same code is executed regardless ret value, so this test
> can be removed.
> Also fix coverity scan CID 1268786.
> 
> Signed-off-by: Laurent Navet <laurent.navet@...il.com>
Applied to the togreg branch of iio.git.  Will push out
as testing when not stuck in a cleanroom with no net access
(but curiously with my less than entirely clean laptop ;)

Jonathan
> ---
>  drivers/iio/industrialio-buffer.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index df919f4..e7fbcce 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -806,8 +806,6 @@ static ssize_t iio_buffer_store_enable(struct device *dev,
>  		ret = __iio_update_buffers(indio_dev,
>  					 NULL, indio_dev->buffer);
>  
> -	if (ret < 0)
> -		goto done;
>  done:
>  	mutex_unlock(&indio_dev->mlock);
>  	return (ret < 0) ? ret : len;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/