linux-kernel - Re: [PATCH RESEND 2] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1433195008.4861.53.camel@perches.com>
Date:	Mon, 01 Jun 2015 14:43:28 -0700
From:	Joe Perches <joe@...ches.com>
To:	Gaston Gonzalez <gascoar@...il.com>
Cc:	gregkh@...uxfoundation.org, cristina.opriceana@...il.com,
	hamohammed.sa@...il.com, gdonald@...il.com,
	mahfouz.saif.elyazal@...il.com, paul.gortmaker@...driver.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 2] staging: rtl8192u: ieee80211: Fix sparse
 endianness warnings

On Mon, 2015-06-01 at 18:30 -0300, Gaston Gonzalez wrote:
> Fix the following sparse warnings:
[]
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
[]
> @@ -660,8 +660,9 @@ inline struct sk_buff *ieee80211_authentication_req(struct ieee80211_network *be
>  	auth = (struct ieee80211_authentication *)
>  		skb_put(skb, sizeof(struct ieee80211_authentication));
>  
> -	auth->header.frame_ctl = IEEE80211_STYPE_AUTH;
> -	if (challengelen) auth->header.frame_ctl |= IEEE80211_FCTL_WEP;
> +	auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH);
> +	if (challengelen)
> +	  auth->header.frame_ctl |= cpu_to_le16(IEEE80211_FCTL_WEP);

It'd be better to use normal tab indentation and likely
it'd also be better to set this only once

	if (challengelen)
		auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH | IEEE80211_FCTL_WEP);
	else
		auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH);

or maybe a single line

	auth->header.frame_ctl = cpu_to_le16(challengelen ? IEEE80211_STYPE_AUTH | IEEE80211_FCTL_WEP : IEEE80211_STYPE_AUTH);

though I think the first is simpler to read.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/