linux-kernel - Re: [PATCH 2/3 v4] Staging: rtl8192u: Remove two useless lines at ieee80211_wep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150602052137.GA22211@kroah.com>
Date:	Tue, 2 Jun 2015 14:21:37 +0900
From:	Greg KH <gregkh@...uxfoundation.org>
To:	pmarzo <marzo.pedro@...il.com>
Cc:	navyasri.tech@...il.com, dilekuzulmez@...il.com, joe@...ches.com,
	haticeerturk27@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3 v4] Staging: rtl8192u: Remove two useless lines at
 ieee80211_wep_null

On Tue, Jun 02, 2015 at 12:19:12AM +0200, pmarzo wrote:
> On Sun, 2015-05-31 at 10:39 +0900, Greg KH wrote:
> > On Thu, May 21, 2015 at 02:25:18AM +0200, Pedro Marzo Perez wrote:
> > > Remove two lines at ieee80211_wep_null which checkpatch.pl reported as errors.
> > > The first one because it has a C99 comment style and the second one because it is a void
> > > return which is useless.
> > > 
> > > Signed-off-by: Pedro Marzo Perez <marzo.pedro@...il.com>
> > > ---
> > >  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 2 --
> > >  1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> > > index bd789d1..94622cc 100644
> > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> > > @@ -279,6 +279,4 @@ void __exit ieee80211_crypto_wep_exit(void)
> > >  
> > >  void ieee80211_wep_null(void)
> > >  {
> > > -//	printk("============>%s()\n", __func__);
> > > -	return;
> > >  }
> > 
> > Please just delete the function.
> 
> It is not so easy, the function is exported at file
> drivers/staging/rtl8192u/ieee80211/ieee80211.h and used at
> drivers/staging/rtl8192u/ieee80211/ieee80211_module.c line 179 with
> several other "null" functions, it seems a dirty trick to force module
> loading:
> /* These function were added to load crypte module autoly */
>     ieee80211_tkip_null();
>     ieee80211_wep_null();
>     ieee80211_ccmp_null();
> 
> I guess all this stuff should be rewritten to force the autoload
> properly but I don't have the knowledge to fix all this.
> Sorry Greg :-(

Ugh, that's a mess.  Ok, I'll take this patch again, please resend it.

thanks,

greg k-h
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/