linux-kernel - Re: [PATCH 03/12] Staging: sm750fb: sm750.h: Insert spaces after commas.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 2 Jun 2015 11:55:50 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Isaac Assegai <isaac.a.travers@...il.com>
Cc:	gregkh@...uxfoundation.org, teddy.wang@...iconmotion.com,
	linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/12] Staging: sm750fb: sm750.h: Insert spaces after
 commas.

On Sun, May 31, 2015 at 10:01:04PM -0700, Isaac Assegai wrote:
> Insert Spaces after commas to rectify the
> following checkpatch errors in sm750.h:
> ERROR: space required after that ','
> 
> Signed-off-by: Isaac Assegai <isaac.a.travers@...il.com>
> ---
>  drivers/staging/sm750fb/sm750.h | 35 ++++++++++++++++++-----------------
>  1 file changed, 18 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
> index 5528912..5f86077 100644
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -12,7 +12,7 @@
>  #define MB(x) ((x)<<20)
>  #define MHZ(x) ((x) * 1000000)
>  /* align should be 2,4,8,16 */
> -#define PADDING(align,data) (((data)+(align)-1)&(~((align) -1)))
> +#define PADDING(align, data) (((data)+(align)-1)&(~((align) -1)))
>  extern int smi_indent;
>  
>  
> @@ -27,15 +27,16 @@ struct lynx_accel{
>  
>  
> -	int (*de_imageblit)(struct lynx_accel *,const char *,u32,u32,u32,
> -						u32,u32,u32,u32,u32,u32,u32,u32,u32);
> +	int (*de_imageblit)(struct lynx_accel *, const char *, u32, u32, u32, u32, 
										^^^^^
oops, trailing whitespace errors :(
> +							       u32, u32, u32, u32, 
										^^^^^
here also
please test your patch with checkpatch before sending

regards
sudip

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/