linux-kernel - Re: [PATCH 12/12] Staging: sm750fb: Insert spaces after commas in three files.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150602075522.GA10942@ubuntu-desktop>
Date:	Tue, 2 Jun 2015 00:55:22 -0700
From:	Isaac Assegai <isaac.a.travers@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	gregkh@...uxfoundation.org, teddy.wang@...iconmotion.com,
	linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/12] Staging: sm750fb: Insert spaces after commas in
 three files.

On Tue, Jun 02, 2015 at 12:18:06PM +0530, Sudip Mukherjee wrote:
> On Sun, May 31, 2015 at 10:01:13PM -0700, Isaac Assegai wrote:
> > Insert Spaces after commas to rectify the following checkpatch
> > errors in ddk750_mode.c, sm750_accel.c and sm750_help.h:
> > ERROR: space required after that ','
> > 
> > Signed-off-by: Isaac Assegai <isaac.a.travers@...il.com>
> > ---
> >  drivers/staging/sm750fb/ddk750_mode.c | 46 +++++++++++++++++------------------
> >  drivers/staging/sm750fb/sm750_accel.c |  2 +-
> >  drivers/staging/sm750fb/sm750_help.h  |  2 +-
> >  3 files changed, 25 insertions(+), 25 deletions(-)
> > 
> > diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> > index 4e252fb..a054747 100644
> > --- a/drivers/staging/sm750fb/ddk750_mode.c
> > +++ b/drivers/staging/sm750fb/ddk750_mode.c
> > @@ -101,29 +101,29 @@ static int programModeRegisters(mode_parameter_t * pModeParam, pll_value_t * pll
> >              | FIELD_VALUE(0, CRT_VERTICAL_SYNC, START, pModeParam->vertical_sync_start - 1));
> >  
> >  
> > -		ulTmpValue = FIELD_VALUE(0, CRT_DISPLAY_CTRL,VSYNC_PHASE, pModeParam->vertical_sync_polarity)|
> > +		ulTmpValue = FIELD_VALUE(0, CRT_DISPLAY_CTRL, VSYNC_PHASE, pModeParam->vertical_sync_polarity)|
> >  					  FIELD_VALUE(0, CRT_DISPLAY_CTRL, HSYNC_PHASE, pModeParam->horizontal_sync_polarity)|
> > -					  FIELD_SET(0, CRT_DISPLAY_CTRL, TIMING,ENABLE)|
> > -					  FIELD_SET(0,CRT_DISPLAY_CTRL,PLANE,ENABLE);
> > +					  FIELD_SET(0, CRT_DISPLAY_CTRL, TIMING, ENABLE)|
> > +					  FIELD_SET(0, CRT_DISPLAY_CTRL, PLANE, ENABLE);
> I am getting confused now.
> This part you have modified in patch 10/12 and i just replied that
> you have missed two modifications.
> 
> regards
> sudip
Thanks for your feedback Sudip, I have a few questions:
1. After applying the first 11 patches I ran checkpatch again and noticed that
I missed three warnings so I ran a 12th patch fixing them. That's why you
see the 12th patch modifying a file that another patch already touched.
What should be done in this type of situation?

2. On Patch 3 you pointed out two trailing whitespace errors.
I ran checkpatch on all the patches before I sent them to
make sure I didn't introduce any new errors, however
there are *many* warnings and errors showing up from
the poor styling already present and I missed these
whitespace errors in the mess.
Can I make checkpatch suppress any errors that might have already
been present in the code and only show me those issues introduced
by the patch itself? If not, how did you identify it?

Thanks,
Isaac
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/