linux-kernel - Re: [PATCH 2/2] pinctrl: mediatek: Fix pinctrl register irq fail bug.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbCSBZ9eokjdA+88Yg9A3-Hz1sH93nB1H2qgv7Q+pRS9Q@mail.gmail.com>
Date:	Tue, 2 Jun 2015 11:08:43 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Hongzhou Yang <hongzhou.yang@...iatek.com>
Cc:	Matthias Brugger <matthias.bgg@...il.com>,
	Yingjoe Chen <yingjoe.chen@...iatek.com>,
	Chaotian Jing <chaotian.jing@...iatek.com>,
	Fabian Frederick <fabf@...net.be>,
	Axel Lin <axel.lin@...ics.com>,
	Maoguang Meng <maoguang.meng@...iatek.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	linux-mediatek@...ts.infradead.org, srv_heupstream@...iatek.com,
	Sascha Hauer <kernel@...gutronix.de>,
	huang eddie <eddie.huang@...iatek.com>, dandan.he@...iatek.com
Subject: Re: [PATCH 2/2] pinctrl: mediatek: Fix pinctrl register irq fail bug.

On Wed, May 27, 2015 at 11:43 AM, Hongzhou Yang
<hongzhou.yang@...iatek.com> wrote:

> Since mt6397 is no need to support interrupt controller,
> I judged "interrupt-controller" property to skip it last patch.
> But the if judgement should on the contrary, this is a bug.
>
> And find of_property_read_bool is better for this case.
> So using of_property_read_bool instead of of_find_property.
>
> Also fix bug of misuse pointer.
>
> Signed-off-by: Hongzhou Yang <hongzhou.yang@...iatek.com>

Patch applied with Axel's review tag.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/