linux-kernel - Re: [PATCH 1/1] USB-SERIAL : Changing usb_serial_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150602092839.GB5409@localhost>
Date:	Tue, 2 Jun 2015 11:28:39 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Abhishek bist <ishubist@...il.com>
Cc:	Johan Hovold <johan@...nel.org>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] USB-SERIAL : Changing usb_serial_generic_open
 prototype

[ Please avoid top-posting. ]

On Tue, Jun 02, 2015 at 02:49:30PM +0530, Abhishek bist wrote:
> Yes, I gone through this warning. It is because if i want to make this
> compilation warning free
> than i have to change the prototype of a open function pointer
> described in usb_serial_driver
> and changing the prototype over there would affect all the device
> driver lying in usb-serial
> category , which is definitely not recommended.

Exactly. My point was that this change is neither correct or desired.
And that you need to pay attention to any compilation warning that your
changes cause. ;)

>       Anyways i got your point .

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/