linux-kernel - Re: [RFC PATCH v5 00/30] perf tools: filtering events using eBPF programs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150602004836.GA1700@Alexeis-MacBook-Pro.local>
Date:	Mon, 1 Jun 2015 17:48:38 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	namhyung@...nel.org, masami.hiramatsu.pt@...achi.com,
	acme@...nel.org, paulus@...ba.org, a.p.zijlstra@...llo.nl,
	mingo@...hat.com, jolsa@...nel.org, dsahern@...il.com,
	daniel@...earbox.net, brendan.d.gregg@...il.com,
	lizefan@...wei.com, hekuang@...wei.com, xiakaixu@...wei.com,
	linux-kernel@...r.kernel.org, pi3orama@....com
Subject: Re: [RFC PATCH v5 00/30] perf tools: filtering events using eBPF
 programs

On Mon, Jun 01, 2015 at 07:37:46AM +0000, Wang Nan wrote:
> This is the 5th version of patch series which tries to introduce eBPF
> programs to perf. It enables 'perf record' to filter events using eBPF

thanks! As far as I could review this set addresses all of my earlier comments.

>  Patch 4/30 - 22/30 introduce libbpf, which first parse eBPF object
>    files then load maps and programs into kernel.

the libbpf side looks good.
For the patches that I haven't explictly acked yet:
Acked-by: Alexei Starovoitov <ast@...mgrid.com>

>  Patch 23-30 - 30/30 are perf side modifications, introducing
>    new syntax: '--event [.*].(o|bpf)' to enable passing eBPF object
>    files to 'perf record', create probing points and attach programs
>    to those points.

Looks good to me as well.
Arnaldo, please take a deep look :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/