linux-kernel - Re: [PATCH 2/3 v4] Staging: rtl8192u: Remove two useless lines at ieee80211_wep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1433252105.20244.3.camel@CEM14014B>
Date:	Tue, 02 Jun 2015 15:35:05 +0200
From:	pmarzo <marzo.pedro@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	devel@...verdev.osuosl.org, haticeerturk27@...il.com,
	linux-kernel@...r.kernel.org, joe@...ches.com,
	dilekuzulmez@...il.com, navyasri.tech@...il.com
Subject: Re: [PATCH 2/3 v4] Staging: rtl8192u: Remove two useless lines at
 ieee80211_wep_null

On mar, 2015-06-02 at 17:25 +0900, Greg KH wrote:
> On Tue, Jun 02, 2015 at 10:08:19AM +0200, pmarzo wrote:
> > On mar, 2015-06-02 at 14:21 +0900, Greg KH wrote:
> > > On Tue, Jun 02, 2015 at 12:19:12AM +0200, pmarzo wrote:
> > > > On Sun, 2015-05-31 at 10:39 +0900, Greg KH wrote:
> > > > > On Thu, May 21, 2015 at 02:25:18AM +0200, Pedro Marzo Perez wrote:
> > > > > > Remove two lines at ieee80211_wep_null which checkpatch.pl reported as errors.
> > > > > > The first one because it has a C99 comment style and the second one because it is a void
> > > > > > return which is useless.
> > > > > > 
> > > > > > Signed-off-by: Pedro Marzo Perez <marzo.pedro@...il.com>
> > > > > > ---
> > > > > >  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 2 --
> > > > > >  1 file changed, 2 deletions(-)
> > > > > > 
> > > > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> > > > > > index bd789d1..94622cc 100644
> > > > > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> > > > > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> > > > > > @@ -279,6 +279,4 @@ void __exit ieee80211_crypto_wep_exit(void)
> > > > > >  
> > > > > >  void ieee80211_wep_null(void)
> > > > > >  {
> > > > > > -//	printk("============>%s()\n", __func__);
> > > > > > -	return;
> > > > > >  }
> > > > > 
> > > > > Please just delete the function.
> > > > 
> > > > It is not so easy, the function is exported at file
> > > > drivers/staging/rtl8192u/ieee80211/ieee80211.h and used at
> > > > drivers/staging/rtl8192u/ieee80211/ieee80211_module.c line 179 with
> > > > several other "null" functions, it seems a dirty trick to force module
> > > > loading:
> > > > /* These function were added to load crypte module autoly */
> > > >     ieee80211_tkip_null();
> > > >     ieee80211_wep_null();
> > > >     ieee80211_ccmp_null();
> > > > 
> > > > I guess all this stuff should be rewritten to force the autoload
> > > > properly but I don't have the knowledge to fix all this.
> > > > Sorry Greg :-(
> > > 
> > > Ugh, that's a mess.  Ok, I'll take this patch again, please resend it.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > > > 
> > 
> > Ok, no problem, just not sure what do I have to resend.
> > 
> > Should I resend the whole serie of three patches 1/3 2/3 3/3? 
> > I received an e-mail confirming the acceptance of patch 3/3 on your
> > staging tree, no news about patch 1/3 yet, so it may confuse you if I
> > resend all of them.
> 
> Resend whatever I have not yet applied.
> 
> thanks,
> 
> greg k-h

Ok, I will download your staging tree and regenerate patches 1/3 and 2/3
with that git tree. That would be v5 1/2 and 2/2 new patches.
Just one (probably very stupid) question, why do you need me to resend
the patches? I mean, both of them apply cleanly to your staging tree
with patch 3/3 already merged.

regards, Pedro.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/