linux-kernel - Re: [PATCH] watchdog: mena21_wdt: Fix possible NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <556DB350.4000803@roeck-us.net>
Date:	Tue, 02 Jun 2015 06:44:48 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Johannes Thumshirn <jthumshirn@...e.de>,
	Wim Van Sebroeck <wim@...ana.be>
CC:	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: mena21_wdt: Fix possible NULL pointer dereference

On 06/02/2015 03:25 AM, Johannes Thumshirn wrote:
> In a21_wdt_remove() we do a watchdog_unregister_device() on struct
> a21_wdt_drv->wdt but never assign it.
>
> Also move the dev_set_drvdata() call in front of the watchdog_register_device()
> call, so it doesn't look like an error.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>

Good catch.

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/