linux-kernel - Re: [PATCH v3 5/6] i2c: at91: print hardware version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <556DBFAE.3030502@cogentembedded.com>
Date:	Tue, 02 Jun 2015 17:37:34 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Cyrille Pitchen <cyrille.pitchen@...el.com>,
	ludovic.desroches@...el.com, nicolas.ferre@...el.com,
	linux-i2c@...r.kernel.org, wsa@...-dreams.de
CC:	mark.rutland@....com, devicetree@...r.kernel.org,
	pawel.moll@....com, ijc+devicetree@...lion.org.uk,
	linux-kernel@...r.kernel.org, robh+dt@...nel.org,
	galak@...eaurora.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 5/6] i2c: at91: print hardware version

Hello.

On 6/2/2015 4:18 PM, Cyrille Pitchen wrote:

> The probe() function now prints the hardware version of the I2C
> controller.

> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@...el.com>
> ---
>   drivers/i2c/busses/i2c-at91.c | 4 ++++
>   1 file changed, 4 insertions(+)

> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index 67b4f15..340ce2e 100644
> --- a/drivers/i2c/busses/i2c-at91.c
> +++ b/drivers/i2c/busses/i2c-at91.c
[...]
> @@ -872,6 +874,8 @@ static int at91_twi_probe(struct platform_device *pdev)
>   			return rc;
>   	}
>
> +	dev_info(dev->dev, "version: 0x%x\n", at91_twi_read(dev, AT91_TWI_VER));

    Use "%#x" instead please -- it's shorter.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/