linux-kernel - Re: [PATCH v1] staging: lustre: libcfs: add __user annotation in libcfs_ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150602013115.GB23940@kroah.com>
Date:	Tue, 2 Jun 2015 10:31:15 +0900
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	David Decotigny <ddecotig@...il.com>
Cc:	devel@...verdev.osuosl.org, HPDD-discuss@...ts.01.org,
	Andreas Dilger <andreas.dilger@...el.com>,
	Liang Zhen <liang.zhen@...el.com>,
	Peng Tao <bergwolf@...il.com>,
	Doug Oucharek <doug.s.oucharek@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Oleg Drokin <oleg.drokin@...el.com>,
	Amir Shehata <amir.shehata@...el.com>,
	Isaac Huang <he.huang@...el.com>
Subject: Re: [PATCH v1] staging: lustre: libcfs: add __user annotation in
 libcfs_ioctl_data

On Mon, Jun 01, 2015 at 12:21:30PM -0700, David Decotigny wrote:
> Thanks for reviewing.
> 
> The 2 struct members were not marked as __user, which this patch does
> here. This was causing warnings with copy from/to user (see commit
> description). This patch also propagates the annotation to the couple
> of functions that are using those members.

Lustre's structures are a total mess of kernel and user pointers and
trying to properly mark them as which they are supposed to be at what
point in time is a very difficult task.  People keep trying and get it
wrong, so I suggest just leaving this alone until the developers unwind
the structure mess as that will be necessary for this code to get merged
into the main part of the kernel.

sorry,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/