linux-kernel - Re: [PATCH v2 2/2] clk: at91: add Flexcom clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150602190435.4698a4db@bbrezillon>
Date:	Tue, 2 Jun 2015 19:04:35 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	Cyrille Pitchen <cyrille.pitchen@...el.com>
Cc:	<nicolas.ferre@...el.com>, <alexandre.belloni@...e-electrons.com>,
	<linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<robh+dt@...nel.org>, <pawel.moll@....com>, <mark.rutland@....com>,
	<ijc+devicetree@...lion.org.uk>, <galak@...eaurora.org>,
	<devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 2/2] clk: at91: add Flexcom clock

Hi Cyrille,

On Tue, 2 Jun 2015 18:57:19 +0200
Cyrille Pitchen <cyrille.pitchen@...el.com> wrote:

> This driver supports the new Atmel Flexcom. The Flexcom is a wrapper which
> integrates one SPI controller, one I2C controller and one USART. Only one
> function can be enabled at a time. This driver selects the function once for
> all, when the Flexcom is probed, according to the value of the new
> "atmel,flexcom-mode" device tree property.
> 
> This driver has chosen to present the Flexcom to the system as a clock so the
> implementation is seamless for the existing Atmel SPI, I2C and USART drivers.

Could detail a bit more why you chose to represent this flexcom IP as
a clock device ?

I don't like to use this 'DT should represent real hardware' argument,
but to me, it looks like you're trying to use a false hardware
representation to avoid changing the peripheral drivers code, which is
wrong since the DT is supposed to represent the hardware blocks.

How about representing the flexcom as an MFD instead ?

Best Regards,

Boris


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/