linux-kernel - Re: [PATCH v4 01/25] linux/time64.h:Introduce the 'struct itimerspec64' for 64bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 2 Jun 2015 21:19:35 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Baolin Wang <baolin.wang@...aro.org>
cc:	arnd@...db.de, john.stultz@...aro.org,
	linux-kernel@...r.kernel.org, y2038@...ts.linaro.org
Subject: Re: [PATCH v4 01/25] linux/time64.h:Introduce the 'struct itimerspec64'
 for 64bit

On Mon, 1 Jun 2015, Baolin Wang wrote:

> Subject: linux/time64.h:Introduce the 'struct itimerspec64' for 64bit

This subject line is wrong in several aspects:

 - linux/time64.h is a file name and does not describe the subsystem
   you are changing. 'time:' is the proper choice here

 - Missing space between colon and first word of the sentence

 - What means struct itimerspec64 for 64bit? Is this a 64bit only
   variant or what?

"Subject: time: Introduce struct itimerspec64"

is the proper subject line as it names the subsystem (time) and tells
clearly what the patch does.

> This patch introduces the 'struct itimerspec64' for 64bit to replace itimerspec,

Again: 'for 64bit' is really wrong here.

> and also introduces the conversion methods: itimerspec64_to_itimerspec() and
> itimerspec_to_itimerspec64(), that makes itimerspec ready for 2038 year.

You explain in great length WHAT the patch is doing, which is
pointless because one can see that from the patch itself. You should
explain WHY you are doing this first.

"itimerspec is not year 2038 safe on 32bit systems due to the
 limitation of the struct timespec members. Introduce itimerspec64
 which uses struct timespec64 instead and provide conversion
 functions"

Hmm?

> +struct itimerspec64 {
> +	struct timespec64 it_interval;  /* timer period */
> +	struct timespec64 it_value;     /* timer expiration */

I really hate tail comments. If you want to document your structure
use proper KernelDoc for it.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/