linux-kernel - Re: [PATCH] power_supply: bq25890: make chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150602192817.GB13930@earth>
Date:	Tue, 2 Jun 2015 21:28:17 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Laurentiu Palcu <laurentiu.palcu@...el.com>
Cc:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power_supply: bq25890: make chip_id int

Hi Laurentiu,

On Tue, Jun 02, 2015 at 01:36:51PM +0300, Laurentiu Palcu wrote:
> Smatch static checker correctly detected an impossible condition because
> chip_id was declared as u8, instead of int:
> 
> drivers/power/bq25890_charger.c:843 bq25890_probe()
> warn: impossible condition '(bq->chip_id < 0) => (0-255 < 0)'
> 
> Also, while at it, fix the return value too.

Thanks, queued for 4.2.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)