linux-kernel - Re: [PATCH v0] softirq: Call trace_preempt_on manually to prevent lockdep splatter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1506022137090.20347@nanos>
Date:	Tue, 2 Jun 2015 21:37:58 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Daniel Wagner <daniel.wagner@...-carit.de>
cc:	Steven Rostedt <rostedt@...dmis.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v0] softirq: Call trace_preempt_on manually to prevent
 lockdep splatter

On Thu, 28 May 2015, Daniel Wagner wrote:

> __do_softirq() uses __local_bh_disable_ip(SOFTIRQ_OFFSET) to disable
> SOFTIRQs and signaling that softirqs are served.
> 
> When done, __do_softirq() calls __local_bh_enable(SOFTIRQ_OFFSET)
> to enable them again. The reason it does not call
> __local_bh_enable_ip(SOFTIRQ_OFFSET) is because __local_bh_enable_ip()
> would process still-pending softirqs.
> 
> Now, we face the same problem as in __local_bh_disable_ip()
> with the preempt tracer hooking into preempt_count_sub(). This
> will case lockdep warning, when for example the kernel is configured
> to run all IRQs as threads and preemptoff tracer is activated:

.... 

> Signed-off-by: Daniel Wagner <daniel.wagner@...-carit.de>

Acked-by: Thomas Gleixner <tglx@...utronix.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/