[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1433281318.4861.105.camel@perches.com>
Date: Tue, 02 Jun 2015 14:41:58 -0700
From: Joe Perches <joe@...ches.com>
To: John Stultz <john.stultz@...aro.org>
Cc: Thomas Gleixner <tglx@...utronix.de>,
Nicholas Mc Guire <hofrat@...dl.org>,
Michal Marek <mmarek@...e.cz>,
Masahiro Yamada <yamada.m@...panasonic.com>,
Sam Ravnborg <sam@...nborg.org>,
"H. Peter Alvin" <hpa@...or.com>, Andrew Hunter <ahh@...gle.com>,
Paul Turner <pjt@...gle.com>,
lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] time: allow gcc to fold constants when possible
On Tue, 2015-06-02 at 14:31 -0700, John Stultz wrote:
> On Tue, Jun 2, 2015 at 2:23 PM, Thomas Gleixner <tglx@...utronix.de> wrote:
> > On Thu, 28 May 2015, Joe Perches wrote:
> >> On Thu, 2015-05-28 at 19:09 +0200, Nicholas Mc Guire wrote:
> >> > To allow constant folding in usecs_to_jiffies() conditionally calls
> >> > the HZ dependent _usecs_to_jiffies() helpers or, when gcc can not
> >> > figure out constant folding, __usecs_to_jiffies, which is the renamed
> >> > original usecs_to_jiffies() function.
> >>
> >> Hi Nicholas.
> >>
> >> Thanks for following through with this.
> >>
> >> The subject might be nicer if it referenced usecs_to_jiffies
> >> instead of being a bit generic.
> >>
> >> Maybe something like:
> >>
> >> time: allow gcc to fold usecs_to_jiffies(constant)
> >
> > And for correctness sake the first letter after the colon, i.e. the
> > one starting the sentence wants to be uppercase.
>
> Is this something that would be worth adding to checkpatch?
Probably not as different people have different standards.
$ git log --no-merges --pretty=oneline -10000 | \
cut -f2- -d" " | \
sed -r -e 's/^.*:\s+//' -e 's/^(.).*/\1/' | \
sort | uniq -c
It's about 50:50 upper case to lower case
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists