linux-kernel - Re: [RFC 8/9] net: dsa: mv88e6352: set port 802.1Q mode to Secure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <866754493.893733.1433288712367.JavaMail.zimbra@savoirfairelinux.com>
Date:	Tue, 2 Jun 2015 19:45:12 -0400 (EDT)
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	netdev <netdev@...r.kernel.org>, David <davem@...emloft.net>,
	Florian Fainelli <f.fainelli@...il.com>,
	Andrew Lunn <andrew@...n.ch>,
	Scott Feldman <sfeldma@...il.com>,
	Jiri Pirko <jiri@...nulli.us>,
	Jérome Oufella 
	<jerome.oufella@...oirfairelinux.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	kernel <kernel@...oirfairelinux.com>,
	Chris Healy <cphealy@...il.com>
Subject: Re: [RFC 8/9] net: dsa: mv88e6352: set port 802.1Q mode to Secure

Hi Guenter,

On Jun 2, 2015, at 10:31 AM, Guenter Roeck linux@...ck-us.net wrote:
On 06/01/2015 06:27 PM, Vivien Didelot wrote:
>> This commit changes the 802.1Q mode of each port from Disabled to
>> Secure. This enables the VLAN support, by checking the VTU entries on
>> ingress.
>>
>> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
>> ---
>>   drivers/net/dsa/mv88e6xxx.c | 14 +++++++-------
>>   drivers/net/dsa/mv88e6xxx.h |  5 +++++
>>   2 files changed, 12 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
>> index ed49bd8..35243d8 100644
>> --- a/drivers/net/dsa/mv88e6xxx.c
>> +++ b/drivers/net/dsa/mv88e6xxx.c
>> @@ -1723,13 +1723,11 @@ static int mv88e6xxx_setup_port(struct dsa_switch *ds,
>> int port)
>>              goto abort;
>>      }
>>
>> -    /* Port Control 2: don't force a good FCS, set the maximum
>> -     * frame size to 10240 bytes, don't let the switch add or
>> -     * strip 802.1q tags, don't discard tagged or untagged frames
>> -     * on this port, do a destination address lookup on all
>> -     * received packets as usual, disable ARP mirroring and don't
>> -     * send a copy of all transmitted/received frames on this port
>> -     * to the CPU.
>> +    /* Port Control 2: don't force a good FCS, set the maximum frame size to
>> +     * 10240 bytes, enable secure 802.1q tags, don't discard tagged or
>> +     * untagged frames on this port, do a destination address lookup on all
>> +     * received packets as usual, disable ARP mirroring and don't send a
>> +     * copy of all transmitted/received frames on this port to the CPU.
>>       */
>>      reg = 0;
>>      if (mv88e6xxx_6352_family(ds) || mv88e6xxx_6351_family(ds) ||
>> @@ -1751,6 +1749,8 @@ static int mv88e6xxx_setup_port(struct dsa_switch *ds, int
>> port)
>>              reg |= PORT_CONTROL_2_FORWARD_UNKNOWN;
>>      }
>>
>> +    reg |= PORT_CONTROL_2_8021Q_SECURE;
>> +
> 
> Hi Vivien,
> 
> Unless I misunderstand the documentation, this effectively disables VLAN
> support on non-bridge ports, especially since the ndo_ functions to add VLAN
> entries to such ports are not implemented. Is that intentional, or am I
> missing something ?

Indeed, I intentionaly set the port mode to Secure to work on 802.1q.
For both cases, the Fallback mode should be enough; this mode checks the
VTU for a valid entry, otherwise checks the port-based VLAN map.

Supporting port-based VLAN looks like another tricky thread.

Ideally, this must be configurable. In my case I do need strict 802.1q.
Can ethtool/iproute2 can do something about the port 802.1q mode?

Thanks,
-v
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/