linux-kernel - Re: [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <556E428B.8070008@samsung.com>
Date:	Wed, 03 Jun 2015 08:55:55 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Andreas Färber <afaerber@...e.de>,
	linux-samsung-soc@...r.kernel.org
Cc:	Kukjin Kim <kgene@...nel.org>,
	김학주 <ruppi.kim@...dkernel.com>,
	Tomasz Figa <tomasz.figa@...il.com>,
	Humberto Naves <hsnaves@...il.com>,
	Jan Kiszka <jan.kiszka@...mens.com>,
	Johann Pfefferl <johann.pfefferl@...mens.com>,
	Ben Gamari <bgamari.foss@...il.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu

On 02.06.2015 22:38, Andreas Färber wrote:
> Am 02.06.2015 um 22:02 schrieb Krzysztof Kozlowski:
>> W dniu 16.03.2015 o 07:00, Andreas Färber pisze:
>>> Signed-off-by: Hakjoo Kim <ruppi.kim@...dkernel.com>
>>> Signed-off-by: Andreas Färber <afaerber@...e.de>
>>> ---
>>>  v2 -> v3: Unchanged
>>>  
>>>  v1 -> v2:
>>>  * Filled in Sob from Hakjoo Kim
>>>  
>>>  arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +++++++++++++++++++++++++
>>>  1 file changed, 25 insertions(+)
>>
>> What is the rationale behind doing this in separate patch, not as part
>> of 2/5? You can just add new board DTS with all of its features at once,
>> but maybe I am missing something?
> 
> This patch depends on the pinctrl driver, 2/5 on nothing.
> 
> By keeping it a separate patch it was intended to go in more quickly
> (clear fail there ;)) and it's easier to review the actual changes -
> squashing is always easier than picking apart.

OK, I'm fine with it.

The patch looks good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Can you resend everything with the change in chosen/console?

Best regards,
Krzysztof


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/