linux-kernel - Re: [PATCH v3 1/2] staging: ion: Add generic ion-physmem driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150603061537.GC4936@sudip-PC>
Date:	Wed, 3 Jun 2015 11:45:37 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Andrew Andrianov <andrew@...mnt.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	pebolle@...cali.nl,
	Arve Hj�nnev�g <arve@...roid.com>,
	Riley Andrews <riandrews@...roid.com>,
	Chen Gang <gang.chen.5i5j@...il.com>,
	Fabian Frederick <fabf@...net.be>,
	Android Kernel Team <kernel-team@...roid.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] staging: ion: Add generic ion-physmem driver

On Tue, Jun 02, 2015 at 07:00:39PM +0300, Andrew Andrianov wrote:
> From: Andrew 'Necromant' Andrianov <andrew@...mnt.org>
> 
> This patch adds a generic ion driver that allows
> ion heaps to be added via devicetree. It provides
> a simple and generic way to feed physical memory regions
> to ion without writing a custom driver, e.g.
> 
> 	ion_sram: ion@...0100000 {
> 	     compatible = "ion,physmem";
> 	     reg = <0x00100000 0x40000>;
> 	     reg-names = "memory";
> 	     ion-heap-id   = <1>;
> 	     ion-heap-type = <ION_HEAP_TYPE_DMA>;
> 	     ion-heap-align = <0x10>;
> 	     ion-heap-name = "SRAM";
> 	};
> 
> Signed-off-by: Andrew Andrianov <andrew@...mnt.org>

Your From: name and Signed-off-by: name is not matching.
But why you are using this extra From: line? you email header From:
is same as your Signed-off-by.

And since you are adding new files it would be better if you can fix
few checkpatch warnings it has. like:

CHECK: Prefer kzalloc(sizeof(*ipdev)...) over kzalloc(sizeof(struct physmem_ion_dev)...)
CHECK: Alignment should match open parenthesis
CHECK: No space is necessary after a cast
CHECK: Please don't use multiple blank lines

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/