linux-kernel - Re: [PATCH] ASoC: core: Pass kcontrol pointer to bytes tlv callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOV7ByLAwtv1n4wdww=5r7wvCDOtwh7+g_3AqZAaPF=R8zmsTg@mail.gmail.com>
Date:	Wed, 3 Jun 2015 14:10:28 -0700
From:	Ben Zhang <benzh@...omium.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	Omair Mohammed Abdullah <omair.m.abdullah@...el.com>,
	Vinod Koul <vinod.koul@...el.com>,
	Dylan Reid <dgreid@...omium.org>,
	alsa-devel <alsa-devel@...a-project.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: core: Pass kcontrol pointer to bytes tlv callbacks

On Wed, Jun 3, 2015 at 4:59 AM, Mark Brown <broonie@...nel.org> wrote:
> On Tue, Jun 02, 2015 at 03:24:03PM -0700, Ben Zhang wrote:
>
>> -     int (*get)(unsigned int __user *bytes, unsigned int size);
>> -     int (*put)(const unsigned int __user *bytes, unsigned int size);
>> +     int (*get)(struct snd_kcontrol *kcontrol,
>> +                unsigned int __user *bytes, unsigned int size);
>> +     int (*put)(struct snd_kcontrol *kcontrol,
>> +                const unsigned int __user *bytes, unsigned int size);
>
> This doesn't update any users and we do have some like the Haswell PCM
> driver.

Hi Mark,

I couldn't find any existing users of the callbacks. It looks like the
modified callbacks are used by SND_SOC_BYTES_TLV only, and there is no
reference to SND_SOC_BYTES_TLV in the kernel.

The Haswell PCM driver uses SND_SOC_BYTES_EXT which doesn't use the
callbacks in struct soc_bytes_ext. The xhandler_get/put are assigned
to snd_kcontrol_new.get/put instead.

Ben
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/