linux-kernel - Re: [PATCH v4 1/1] x86_64: fix KASan shadow region page tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <556EBCC3.4070500@ptsecurity.com>
Date:	Wed, 3 Jun 2015 11:37:23 +0300
From:	Alexander Popov <alpopov@...ecurity.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrey Ryabinin <a.ryabinin@...sung.com>,
	Andrey Konovalov <adech.fo@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Kees Cook <keescook@...omium.org>,
	"Peter Zijlstra (Intel)" <peterz@...radead.org>,
	Andy Lutomirski <luto@...capital.net>,
	Alexander Kuleshov <kuleshovmail@...il.com>,
	"Borislav Petkov" <bp@...e.de>,
	Denys Vlasenko <dvlasenk@...hat.com>, <x86@...nel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/1] x86_64: fix KASan shadow region page tables

On 03.06.2015 10:44, Ingo Molnar wrote:
> 
> * Alexander Popov <alpopov@...ecurity.com> wrote:
>> +	kasan_early_init();
>> +	kasan_map_early_shadow(early_level4_pgt);
> 
> So why isn't kasan_map_early_shadow() called in kasan_early_init()?
> 
> High level x86 init code should not be polluted with too many low level details.

Hello, Ingo.

kasan_map_early_shadow() is called twice in x86_64_start_kernel():
once for early_level4_pgt and then later for init_level4_pgt.

I've decided to introduce separate kasan_early_init() to avoid big changes
which can bring consequences that I don't understand.

Best regards,
Alexander
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/