linux-kernel - Re: [PATCH] sctp: Make the function sctp_chunk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150603102254.GA7234@hmsreliant.think-freely.org>
Date:	Wed, 3 Jun 2015 06:22:54 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	vyasevich@...il.com, davem@...emloft.net,
	linux-sctp@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sctp: Make the function sctp_chunk_abandoned bool

On Wed, Jun 03, 2015 at 12:02:53AM -0400, Nicholas Krause wrote:
> This makes the function sctp_chunk_abandoned bool due to this
> function only returning either one or zero as its return value.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  include/net/sctp/structs.h | 2 +-
>  net/sctp/chunk.c           | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
> index 2bb2fcf..2691490 100644
> --- a/include/net/sctp/structs.h
> +++ b/include/net/sctp/structs.h
> @@ -535,7 +535,7 @@ struct sctp_datamsg *sctp_datamsg_from_user(struct sctp_association *,
>  void sctp_datamsg_free(struct sctp_datamsg *);
>  void sctp_datamsg_put(struct sctp_datamsg *);
>  void sctp_chunk_fail(struct sctp_chunk *, int error);
> -int sctp_chunk_abandoned(struct sctp_chunk *);
> +bool sctp_chunk_abandoned(struct sctp_chunk *);
>  
>  /* RFC2960 1.4 Key Terms
>   *
> diff --git a/net/sctp/chunk.c b/net/sctp/chunk.c
> index a338091..7bd1991 100644
> --- a/net/sctp/chunk.c
> +++ b/net/sctp/chunk.c
> @@ -344,17 +344,17 @@ errout:
>  }
>  
>  /* Check whether this message has expired. */
> -int sctp_chunk_abandoned(struct sctp_chunk *chunk)
> +bool sctp_chunk_abandoned(struct sctp_chunk *chunk)
>  {
>  	struct sctp_datamsg *msg = chunk->msg;
>  
>  	if (!msg->can_abandon)
> -		return 0;
> +		return false;
>  
>  	if (time_after(jiffies, msg->expires_at))
> -		return 1;
> +		return true;
>  
> -	return 0;
> +	return false;
>  }
>  
>  /* This chunk (and consequently entire message) has failed in its sending. */
> -- 
> 2.1.4
> 
> 
Seems reasonable
Acked-by: Neil Horman <nhorman@...driver.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/