linux-kernel - Re: [PATCH] kdbus: kdbus_item_validate(): remove duplicated code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANq1E4Qzhtx0gVTi04CK8ixboY673a5qEccptrWxnRbV=-dDsQ@mail.gmail.com>
Date:	Wed, 3 Jun 2015 12:31:22 +0200
From:	David Herrmann <dh.herrmann@...il.com>
To:	Sergei Zviagintsev <sergei@...v.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Daniel Mack <daniel@...que.org>,
	David Herrmann <dh.herrmann@...glemail.com>,
	Djalal Harouni <tixxdz@...ndz.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kdbus: kdbus_item_validate(): remove duplicated code

Hi

On Tue, Jun 2, 2015 at 5:48 PM, Sergei Zviagintsev <sergei@...v.net> wrote:
> KDBUS_ITEM_PAYLOAD_VEC and KDBUS_ITEM_PAYLOAD_OFF cases use literally
> the same code, so merge them.
>
> Signed-off-by: Sergei Zviagintsev <sergei@...v.net>
> ---
>  ipc/kdbus/item.c | 6 ------
>  1 file changed, 6 deletions(-)

Reviewed-by: David Herrmann <dh.herrmann@...il.com>

Thanks
David

> diff --git a/ipc/kdbus/item.c b/ipc/kdbus/item.c
> index 745ad5495096..1ee72c2ad7c3 100644
> --- a/ipc/kdbus/item.c
> +++ b/ipc/kdbus/item.c
> @@ -96,12 +96,6 @@ int kdbus_item_validate(const struct kdbus_item *item)
>                 break;
>
>         case KDBUS_ITEM_PAYLOAD_VEC:
> -               if (payload_size != sizeof(struct kdbus_vec))
> -                       return -EINVAL;
> -               if (item->vec.size == 0 || item->vec.size > SIZE_MAX)
> -                       return -EINVAL;
> -               break;
> -
>         case KDBUS_ITEM_PAYLOAD_OFF:
>                 if (payload_size != sizeof(struct kdbus_vec))
>                         return -EINVAL;
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/