linux-kernel - Re: [PATCH] kdbus: kdbus_conn_connect(): use `bus' instead of `conn->ep->bus'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANq1E4Qo_wZnuE4ECv50x29-ZqZ4kTad78EwcuCpCtY_i=sCQg@mail.gmail.com>
Date:	Wed, 3 Jun 2015 12:32:28 +0200
From:	David Herrmann <dh.herrmann@...il.com>
To:	Sergei Zviagintsev <sergei@...v.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Daniel Mack <daniel@...que.org>,
	David Herrmann <dh.herrmann@...glemail.com>,
	Djalal Harouni <tixxdz@...ndz.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kdbus: kdbus_conn_connect(): use `bus' instead of `conn->ep->bus'

Hi

On Tue, Jun 2, 2015 at 5:48 PM, Sergei Zviagintsev <sergei@...v.net> wrote:
> Local `bus' is already set to `conn->ep->bus'. Use it.
>
> Signed-off-by: Sergei Zviagintsev <sergei@...v.net>
> ---
>  ipc/kdbus/connection.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: David Herrmann <dh.herrmann@...il.com>

Thanks
David

> diff --git a/ipc/kdbus/connection.c b/ipc/kdbus/connection.c
> index b00872edbbc9..b9f13749a748 100644
> --- a/ipc/kdbus/connection.c
> +++ b/ipc/kdbus/connection.c
> @@ -432,7 +432,7 @@ static int kdbus_conn_connect(struct kdbus_conn *conn, const char *name)
>          * directly, and won't cause any notifications.
>          */
>         if (!kdbus_conn_is_monitor(conn)) {
> -               ret = kdbus_notify_id_change(conn->ep->bus, KDBUS_ITEM_ID_ADD,
> +               ret = kdbus_notify_id_change(bus, KDBUS_ITEM_ID_ADD,
>                                              conn->id, conn->flags);
>                 if (ret < 0)
>                         goto exit_disconnect;
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/