linux-kernel - Re: [PATCH tip] perf tools: Fix a compiling problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cjkjcF_7AeZ0d7kyDLWwjutLpJm-MfdDR42tr=iQYnz6g@mail.gmail.com>
Date:	Wed, 3 Jun 2015 21:30:53 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	Jiri Olsa <jolsa@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...hat.com>, Li Zefan <lizefan@...wei.com>,
	pi3orama@....com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH tip] perf tools: Fix a compiling problem

Hi Wang,

On Wed, Jun 3, 2015 at 5:50 PM, Wang Nan <wangnan0@...wei.com> wrote:
> Commit 4bb11d012ab248d0e383008d725be0d26a74fac2 ("perf tools: Add
> dso__data_get/put_fd()") has a problem: it uses a undefined variable
> 'dso' in find_proc_info(), which should be 'map->dso'. The buggy code
> piece is not compiled if NO_LIBUNWIND_DEBUG_FRAME is not set.
>
> Signed-off-by: Wang Nan <wangnan0@...wei.com>

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks for fixing this!
Namhyung


> ---
>  tools/perf/util/unwind-libunwind.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c
> index f079b63..4c00507 100644
> --- a/tools/perf/util/unwind-libunwind.c
> +++ b/tools/perf/util/unwind-libunwind.c
> @@ -360,7 +360,7 @@ find_proc_info(unw_addr_space_t as, unw_word_t ip, unw_proc_info_t *pi,
>                 unw_word_t base = is_exec ? 0 : map->start;
>
>                 if (fd >= 0)
> -                       dso__data_put_fd(dso);
> +                       dso__data_put_fd(map->dso);
>
>                 memset(&di, 0, sizeof(di));
>                 if (dwarf_find_debug_frame(0, &di, ip, base, map->dso->name,
> --
> 1.8.3.4
>



-- 
Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/