linux-kernel - Re: [PATCH] trivial: fix comment mentioning abandoned ASSIGN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150603151803.GQ5989@linux.vnet.ibm.com>
Date:	Wed, 3 Jun 2015 08:18:03 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Christian Borntraeger <borntraeger@...ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trivial: fix comment mentioning abandoned ASSIGN_ONCE

On Wed, Jun 03, 2015 at 12:16:16AM +0200, Rasmus Villemoes wrote:
> Commit 43239cbe79fc ("kernel: Change ASSIGN_ONCE(val, x) to
> WRITE_ONCE(x, val)") left behind this reference.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>

Reviewed-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

> ---
>  include/linux/compiler.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/compiler.h b/include/linux/compiler.h
> index 867722591be2..38f0668d40aa 100644
> --- a/include/linux/compiler.h
> +++ b/include/linux/compiler.h
> @@ -450,7 +450,7 @@ static __always_inline void __write_once_size(volatile void *p, void *res, int s
>   * with an explicit memory barrier or atomic instruction that provides the
>   * required ordering.
>   *
> - * If possible use READ_ONCE/ASSIGN_ONCE instead.
> + * If possible use READ_ONCE/WRITE_ONCE instead.
>   */
>  #define __ACCESS_ONCE(x) ({ \
>  	 __maybe_unused typeof(x) __var = (__force typeof(x)) 0; \
> -- 
> 2.1.3
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/