linux-kernel - Re: [PATCH 1/1] staging: lustre/lustre/obdclass/llog_cat.c: get rid of sparse context imbalance warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALmu+SyDNhMxu3Hu17=GB_-1tQQmCRAjXrTOjYZ_vU9MbQ=BAQ@mail.gmail.com>
Date:	Wed, 3 Jun 2015 08:47:38 -0700
From:	Tolga Ceylan <tolga.ceylan@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	Greg Donald <gdonald@...il.com>, Joe Perches <joe@...ches.com>,
	Darshana Padmadas <darshanapadmadas@...il.com>,
	Arjun AK <arjunak234@...il.com>, HPDD-discuss@...ts.01.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] staging: lustre/lustre/obdclass/llog_cat.c: get rid
 of sparse context imbalance warning

The second patch is better (it also keeps the lock locked shorter.) Do
I need to resend?

On Tue, Jun 2, 2015 at 11:42 PM, Sudip Mukherjee
<sudipm.mukherjee@...il.com> wrote:
> On Tue, Jun 02, 2015 at 12:57:20PM -0700, Tolga Ceylan wrote:
>> In llog_cat_new_log(), sparse emits a context imbalance (unexpected lock)
>> warning due its inability to detect the noreturn attribute in
>> lbug_with_lock() function inside LBUG macro. Adding a never reached
>> return statement suppresses this warning.
> but adding a statement which never executes, is that the correct solution?
> what about :
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/llog_cat.c b/drivers/staging/lustre/lustre/obdclass/llog_cat.c
> index c8f6ab0..1cb3495 100644
> --- a/drivers/staging/lustre/lustre/obdclass/llog_cat.c
> +++ b/drivers/staging/lustre/lustre/obdclass/llog_cat.c
> @@ -103,13 +103,12 @@ static int llog_cat_new_log(const struct lu_env *env,
>
>         spin_lock(&loghandle->lgh_hdr_lock);
>         llh->llh_count++;
> -       if (ext2_set_bit(index, llh->llh_bitmap)) {
> -               CERROR("argh, index %u already set in log bitmap?\n",
> -                      index);
> -               spin_unlock(&loghandle->lgh_hdr_lock);
> +       rc = ext2_set_bit(index, llh->llh_bitmap);
> +       spin_unlock(&loghandle->lgh_hdr_lock);
> +       if (rc) {
> +               CERROR("argh, index %u already set in log bitmap?\n", index);
>                 LBUG(); /* should never happen */
>         }
> -       spin_unlock(&loghandle->lgh_hdr_lock);
>
>         cathandle->lgh_last_idx = index;
>         llh->llh_tail.lrt_index = index;
>
>
> regards
> sudip
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/