linux-kernel - Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Jun 2015 09:34:47 -0700
From:	Bin Gao <bin.gao@...ux.intel.com>
To:	Peter Hurley <peter@...leysoftware.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Stuart R. Anderson" <stuart.r.anderson@...el.com>,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	Jiri Slaby <jslaby@...e.cz>, Borislav Petkov <bp@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from
 early_prink.c

On Wed, Jun 03, 2015 at 08:35:29AM -0400, Peter Hurley wrote:
> > +/* x86 uses "earlyprintk=xxx", so we keep the compatibility here */
> > +#ifdef CONFIG_X86
> > +static int __init param_setup_earlycon_x86(char *buf)
> > +{
> > +	return param_setup_earlycon(buf);
> > +}
> > +early_param("earlyprintk", param_setup_earlycon_x86);
> 
> I'm concerned that this effectively makes earlyprintk= a synonym for
> earlycon=, which may have unforeseen consequences. I'd rather this
> specifically parse for replacement functionality, ie., only command line
> parameters of the form:
> 
> 	earlyprintk=pciserial,...
> 
> Regards,
> Peter Hurley
> 

Something like this: ?

/*
 * x86 uses "earlyprintk=xxx", so we keep the compatibility here.
 * But we only handle the earlyprintk=uart8250,pci[32]B:D.F[,options] case.
 */
#ifdef CONFIG_X86
static int __init param_setup_earlycon_x86(char *buf)
{
        if (strncmp("uart8250,pci", 12))
                return -EINVAL;
 
        return param_setup_earlycon(buf);
}
early_param("earlyprintk", param_setup_earlycon_x86);

Thanks,
Bin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/