[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150603170658.GB2327@jsakkine-mobl1>
Date: Wed, 3 Jun 2015 20:06:58 +0300
From: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc: peterhuewe@....de, safford@...ibm.com,
Marcel Selhorst <tpmdd@...horst.net>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@...ts.sourceforge.net>,
open list <linux-kernel@...r.kernel.org>,
richard.l.maliszewski@...el.com
Subject: Re: [PATCH] tpm: introduce struct tpm_buf
On Wed, Jun 03, 2015 at 10:48:51AM -0600, Jason Gunthorpe wrote:
> On Wed, Jun 03, 2015 at 07:43:34PM +0300, Jarkko Sakkinen wrote:
> > I realized basically the same what you said here when I refined the
> > patch (read this email after sending v2) :) I decided that align to 8
> > bytes.
>
> Don't use the __attribute__((align)), use just a u64, the effect is
> identical, and the latter doesn't rely on compiler specific features.
Byte array is otherwise more convenient and this feature is widely used:
$ git grep "__attribute__((aligned" | wc -l
222
I don't see your point here.
> > I don't think the packed attribute is needed here because now I cast
> > the beginning to tpm_input_header, which is a packed struct.
>
> I ment the attributs could be changed on the tpm_input_header, the buf
> should just be a u64 array..
>
> Jason
/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists