linux-kernel - Re: [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Jun 2015 10:06:36 -0700
From:	Joe Perches <joe@...ches.com>
To:	Julien Grall <julien.grall@...rix.com>
Cc:	xen-devel@...ts.xenproject.org, ian.campbell@...rix.com,
	stefano.stabellini@...citrix.com, linux-kernel@...r.kernel.org,
	David Vrabel <david.vrabel@...rix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/2] net/xen-netfront: Correct printf format in
 xennet_get_responses

On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote:
> rx->status is an int16_t, print it using %d rather than %u in order to
> have a meaningful value when the field is negative.
[]
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
[]
> @@ -733,7 +733,7 @@ static int xennet_get_responses(struct netfront_queue *queue,
>  		if (unlikely(rx->status < 0 ||
>  			     rx->offset + rx->status > PAGE_SIZE)) {
>  			if (net_ratelimit())
> -				dev_warn(dev, "rx->offset: %x, size: %u\n",
> +				dev_warn(dev, "rx->offset: %x, size: %d\n",

If you're going to do this, perhaps it'd be sensible to
also change the %x to %#x or 0x%x so that people don't
mistake offset without an [a-f] for decimal.

>  					 rx->offset, rx->status);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/