linux-kernel - Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code in arch/x86/entry/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <556F411A.1050409@zytor.com>
Date:	Wed, 03 Jun 2015 11:02:02 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Ingo Molnar <mingo@...nel.org>,
	Andy Lutomirski <luto@...capital.net>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Brian Gerst <brgerst@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Borislav Petkov <bp@...en8.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code
 in arch/x86/entry/

On 06/03/2015 10:13 AM, Ingo Molnar wrote:
>>>
>>> Anyway, I like this series except patch 7.
>>>
>> I can't count.  I mean all except patch 3 (the vdso one), not 7.
>>

Same here... erk.

>> Although arch/x86/entry might be less of a mouthful.
> 
> So see my reply to hpa: it makes sense to collect all things system calls and 
> other entry code in a single place, instead of having it scattered all around.
> 
> Its internal organization is kept intact, so the vDSO code isn't mixed with other 
> bits.

That really doesn't change the fact that it is a completely different
beast, and putting it under entry/ is actively misleading.  Having vdso/
as a separate top level is a good thing, I believe.

I really dislike deep hierarchies, as I said, because my experience has
been that they are more confusing than they are helpful, especially over
time.  The arch-example of badness is of course arch/x86/kernel, which
is a total catch-all, but

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/