linux-kernel - Re: [PATCH v9 2/6] arm64: hi6220: Document devicetree bindings for Hisilicon hi6220 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAL_JsqKhoDe-Z700RnmZXUtFLS_Kpn1wsE2JVo-pu6UGHBJsAw@mail.gmail.com>
Date:	Wed, 3 Jun 2015 23:36:54 -0500
From:	Rob Herring <robherring2@...il.com>
To:	Bintian Wang <bintian.wang@...wei.com>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Kevin Hilman <khilman@...aro.org>,
	Mike Turquette <mturquette@...aro.org>,
	Rob Herring <rob.herring@...aro.org>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	Haojian Zhuang <haojian.zhuang@...aro.org>,
	xuwei5@...ilicon.com, Jaehoon Chung <jh80.chung@...sung.com>,
	Olof Johansson <olof@...om.net>, yanhaifeng@...il.com,
	Stephen Boyd <sboyd@...eaurora.org>, xuejiancheng@...wei.com,
	sledge.yanwei@...wei.com,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	guodong.xu@...aro.org,
	Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>,
	tyler.baker@...aro.org, khilman@...nel.org,
	Paul Bolle <pebolle@...cali.nl>, Arnd Bergmann <arnd@...db.de>,
	Marc Zyngier <marc.zyngier@....com>, xuyiping@...ilicon.com,
	wangbinghui@...ilicon.com, zhenwei.wang@...ilicon.com,
	victor.lixin@...ilicon.com, puck.chen@...ilicon.com,
	dan.zhao@...ilicon.com, huxinwei@...wei.com,
	z.liuxinliang@...wei.com, heyunlei@...wei.com,
	kong.kongxinwei@...ilicon.com, wangbintian@...il.com,
	w.f@...wei.com, liguozhu@...ilicon.com
Subject: Re: [PATCH v9 2/6] arm64: hi6220: Document devicetree bindings for
 Hisilicon hi6220 SoC

On Fri, May 29, 2015 at 8:50 PM, Bintian Wang <bintian.wang@...wei.com> wrote:
> This patch adds documentation for the devicetree bindings used by the
> DT files of Hisilicon hi6220 SoC mobile platform.
>
> Signed-off-by: Bintian Wang <bintian.wang@...wei.com>
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Acked-by: Haojian Zhuang <haojian.zhuang@...aro.org>
> Acked-by: Stephen Boyd <sboyd@...eaurora.org>

Acked-by: Rob Herring <robh@...nel.org>

One minor comment below.

> ---
>  .../bindings/arm/hisilicon/hisilicon.txt           |   87 ++++++++++++++++++++
>  1 file changed, 87 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> index 35b1bd4..f67d0f3 100644
> --- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> +++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> @@ -1,5 +1,8 @@
>  Hisilicon Platforms Device Tree Bindings
>  ----------------------------------------------------
> +Hi6220 SoC
> +Required root node properties:
> +       - compatible = "hisilicon,hi6220";
>
>  Hi4511 Board
>  Required root node properties:
> @@ -13,6 +16,9 @@ HiP01 ca9x2 Board
>  Required root node properties:
>         - compatible = "hisilicon,hip01-ca9x2";
>
> +HiKey Board
> +Required root node properties:
> +       - compatible = "hisilicon,hi6220-hikey", "hisilicon,hi6220";
>
>  Hisilicon system controller
>
> @@ -41,6 +47,87 @@ Example:
>         };
>
>  -----------------------------------------------------------------------
> +Hisilicon Hi6220 system controller
> +
> +Required properties:
> +- compatible : "hisilicon,hi6220-sysctrl"
> +- reg : Register address and size
> +- #clock-cells: should be set to 1, many clock registers are defined
> +  under this controller and this property must be present.
> +
> +Hisilicon designs this controller as one of the system controllers,
> +its main functions are the same as Hisilicon system controller, but
> +the register offset of some core modules are different.
> +
> +Example:
> +       /*for Hi6220*/
> +       sys_ctrl: sys_ctrl {

You should have the unit address in the name here. Same with the
follow examples.

> +               compatible = "hisilicon,hi6220-sysctrl", "syscon";
> +               reg = <0x0 0xf7030000 0x0 0x2000>;
> +               #clock-cells = <1>;
> +       };
> +
> +
> +Hisilicon Hi6220 Power Always ON domain controller
> +
> +Required properties:
> +- compatible : "hisilicon,hi6220-aoctrl"
> +- reg : Register address and size
> +- #clock-cells: should be set to 1, many clock registers are defined
> +  under this controller and this property must be present.
> +
> +Hisilicon designs this system controller to control the power always
> +on domain for mobile platform.
> +
> +Example:
> +       /*for Hi6220*/
> +       ao_ctrl: ao_ctrl {
> +               compatible = "hisilicon,hi6220-aoctrl", "syscon";
> +               reg = <0x0 0xf7800000 0x0 0x2000>;
> +               #clock-cells = <1>;
> +       };
> +
> +
> +Hisilicon Hi6220 Media domain controller
> +
> +Required properties:
> +- compatible : "hisilicon,hi6220-mediactrl"
> +- reg : Register address and size
> +- #clock-cells: should be set to 1, many clock registers are defined
> +  under this controller and this property must be present.
> +
> +Hisilicon designs this system controller to control the multimedia
> +domain(e.g. codec, G3D ...) for mobile platform.
> +
> +Example:
> +       /*for Hi6220*/
> +       media_ctrl: media_ctrl {
> +               compatible = "hisilicon,hi6220-mediactrl", "syscon";
> +               reg = <0x0 0xf4410000 0x0 0x1000>;
> +               #clock-cells = <1>;
> +       };
> +
> +
> +Hisilicon Hi6220 Power Management domain controller
> +
> +Required properties:
> +- compatible : "hisilicon,hi6220-pmctrl"
> +- reg : Register address and size
> +- #clock-cells: should be set to 1, some clock registers are define
> +  under this controller and this property must be present.
> +
> +Hisilicon designs this system controller to control the power management
> +domain for mobile platform.
> +
> +Example:
> +       /*for Hi6220*/
> +       pm_ctrl: pm_ctrl {
> +               compatible = "hisilicon,hi6220-pmctrl", "syscon";
> +               reg = <0x0 0xf7032000 0x0 0x1000>;
> +               #clock-cells = <1>;
> +       };
> +
> +-----------------------------------------------------------------------
>  Hisilicon HiP01 system controller
>
>  Required properties:
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/