[<prev] [next>] [day] [month] [year] [list]
Message-ID: <CABxcv==e1NzDHkZgNU=AH0cG=yj3Fbbnozp63z5niaE5qf3r6w@mail.gmail.com>
Date: Thu, 4 Jun 2015 08:52:30 +0200
From: Javier Martinez Canillas <javier@...hile0.org>
To: Michal Suchanek <hramrach@...il.com>
Cc: Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Russell King <linux@....linux.org.uk>,
Kukjin Kim <kgene@...nel.org>,
Krzysztof Kozlowski <k.kozlowski@...sung.com>,
Vinod Koul <vinod.koul@...el.com>,
Dan Williams <dan.j.williams@...el.com>,
David Woodhouse <dwmw2@...radead.org>,
Brian Norris <computersforpeace@...il.com>,
Han Xu <han.xu@...escale.com>, Mark Brown <broonie@...nel.org>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Marek Vasut <marex@...x.de>,
Rafał Miłecki <zajec5@...il.com>,
Alison Chaiken <alison_chaiken@...tor.com>,
Huang Shijie <b32955@...escale.com>,
Ben Hutchings <ben@...adent.org.uk>,
Knut Wohlrab <knut.wohlrab@...bosch.com>,
Bean Huo 霍斌斌 (beanhuo)
<beanhuo@...ron.com>, "grmoore@...era.com" <grmoore@...era.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Linux Kernel <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-samsung-soc@...r.kernel.org"
<linux-samsung-soc@...r.kernel.org>, dmaengine@...r.kernel.org,
linux-mtd@...ts.infradead.org, linux-spi@...r.kernel.org
Subject: Re: [PATCH 01/11] ARM: dt: Add SPI CS on Samsung Snow board.
Hello Michal,
On Wed, Jun 3, 2015 at 11:26 PM, Michal Suchanek <hramrach@...il.com> wrote:
> Although there is only one choice of chipselect it is necessary to
> specify it. The driver cannot claim the gpio otherwise.
>
> Signed-off-by: Michal Suchanek <hramrach@...il.com>
> ---
> arch/arm/boot/dts/exynos5250-snow.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index 1eca97e..1fa72cf 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -687,9 +687,10 @@
> };
>
> &spi_1 {
> - status = "okay";
> samsung,spi-src-clk = <0>;
> num-cs = <1>;
> + cs-gpios = <&gpa2 5 0>;
> + status = "okay";
Why are you changing the position of the status property? AFAIK the
convention is to have this property at the beginning of the device
node.
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists