linux-kernel - Re: [PATCH] of/fdt: fix argument name and add comments of unflatten_dt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150604055328.6F296C4095F@trevor.secretlab.ca>
Date:	Thu, 04 Jun 2015 14:53:28 +0900
From:	Grant Likely <grant.likely@...aro.org>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	devicetree@...r.kernel.org
Cc:	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of/fdt: fix argument name and add comments of
 unflatten_dt_node()

On Mon, 13 Apr 2015 10:30:20 +0900
, Masahiro Yamada <yamada.masahiro@...ionext.com>
 wrote:
> Match the name of the third argument in the comment block
> to the actual function: p -> poffset
> 
> Add missing comments about the arguments "nodepp" and "dryrun".
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Applied, thanks.

g.

> ---
> 
>  drivers/of/fdt.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 3a896c9..35898ca 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -145,9 +145,12 @@ static void *unflatten_dt_alloc(void **mem, unsigned long size,
>   * unflatten_dt_node - Alloc and populate a device_node from the flat tree
>   * @blob: The parent device tree blob
>   * @mem: Memory chunk to use for allocating device nodes and properties
> - * @p: pointer to node in flat tree
> + * @poffset: pointer to node in flat tree
>   * @dad: Parent struct device_node
> + * @nodepp: The device_node tree created by the call
>   * @fpsize: Size of the node path up at the current depth.
> + * @dryrun: If true, do not allocate device nodes but still calculate needed
> + * memory size
>   */
>  static void * unflatten_dt_node(void *blob,
>  				void *mem,
> -- 
> 1.9.1
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/