lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 03 Jun 2015 17:24:40 -0700 From: Davidlohr Bueso <dave@...olabs.net> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Manfred Spraul <manfred@...orfullife.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] ipc,shm: move BUG_ON check into shm_lock On Mon, 2015-06-01 at 15:52 -0700, Andrew Morton wrote: > On Fri, 29 May 2015 17:03:05 -0700 Davidlohr Bueso <dave@...olabs.net> wrote: > > > Upon every shm_lock call, we BUG_ON if an error was returned, > > indicating racing either in idr or in RMID. Move this logic > > into the locking. > > > > ... > > > > --- a/ipc/shm.c > > +++ b/ipc/shm.c > > @@ -155,8 +155,14 @@ static inline struct shmid_kernel *shm_lock(struct ipc_namespace *ns, int id) > > { > > struct kern_ipc_perm *ipcp = ipc_lock(&shm_ids(ns), id); > > > > - if (IS_ERR(ipcp)) > > + if (IS_ERR(ipcp)) { > > + /* > > + * We raced in the idr lookup or with RMID, > > + * either way, the ID is busted. > > + */ > > + BUG_ON(1); > > return (struct shmid_kernel *)ipcp; > > + } > > Sure, this is fine. Thanks, Davidlohr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists