linux-kernel - Re: [PATCH] staging: fbtft: fix out of bound access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150604122153.GA18177@sudip-PC>
Date:	Thu, 4 Jun 2015 17:51:53 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Noralf Trønnes <noralf@...nnes.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fbtft: fix out of bound access

On Thu, Jun 04, 2015 at 05:12:23AM -0700, Joe Perches wrote:
> On Thu, 2015-06-04 at 17:12 +0530, Sudip Mukherjee wrote:
> > size of str is 16, but in snprintf the size was mentioned as 128.
> []
> > diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
> []
> > @@ -1096,7 +1096,7 @@ static int fbtft_init_display_dt(struct fbtft_par *par)
> >  			/* make debug message */
> >  			msg[0] = '\0';
> >  			for (j = 0; j < i; j++) {
> > -				snprintf(str, 128, " %02X", buf[j]);
> > +				snprintf(str, 16, " %02X", buf[j]);
> 
> using sizeof(str) is probably more robust
> 
> msg isn't big enough to hold the maximum possible output.
yes, it will not hold. i didn't notice msg size.
> 
> If this is really useful, and I rather doubt it is,
> it'd probably be better to use a loop to output
> multiple lines, one for each register.
I will send in a v2 doing this.

regards
sudip
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/